[coreboot-gerrit] Change in coreboot[master]: mb/intel: Get rid of device_t
Elyes HAOUAS (Code Review)
gerrit at coreboot.org
Fri May 4 20:51:15 CEST 2018
Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26090
Change subject: mb/intel: Get rid of device_t
......................................................................
mb/intel: Get rid of device_t
Use of device_t has been abandoned in ramstage.
Change-Id: Ie2c466a280d18979d5f9ca182793ed43431d2010
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/intel/baskingridge/chromeos.c
M src/mainboard/intel/baskingridge/mainboard.c
M src/mainboard/intel/bayleybay_fsp/mainboard.c
M src/mainboard/intel/camelbackmountain_fsp/mainboard.c
M src/mainboard/intel/cannonlake_rvp/mainboard.c
M src/mainboard/intel/cougar_canyon2/mainboard.c
M src/mainboard/intel/cougar_canyon2/romstage.c
M src/mainboard/intel/d510mo/mainboard.c
M src/mainboard/intel/d510mo/romstage.c
M src/mainboard/intel/dcp847ske/mainboard.c
M src/mainboard/intel/emeraldlake2/chromeos.c
M src/mainboard/intel/emeraldlake2/mainboard.c
M src/mainboard/intel/emeraldlake2/romstage.c
M src/mainboard/intel/galileo/gpio.c
M src/mainboard/intel/glkrvp/mainboard.c
M src/mainboard/intel/kblrvp/mainboard.c
M src/mainboard/intel/kunimitsu/mainboard.c
M src/mainboard/intel/minnowmax/mainboard.c
M src/mainboard/intel/stargo2/mainboard.c
M src/mainboard/intel/strago/mainboard.c
M src/mainboard/intel/wtm2/mainboard.c
21 files changed, 27 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/26090/1
diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c
index 5ed9e36..6022078 100644
--- a/src/mainboard/intel/baskingridge/chromeos.c
+++ b/src/mainboard/intel/baskingridge/chromeos.c
@@ -29,7 +29,7 @@
void fill_lb_gpios(struct lb_gpios *gpios)
{
- device_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
+ struct device *dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
u16 gpio_base = pci_read_config32(dev, GPIOBASE) & 0xfffe;
if (!gpio_base)
diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c
index dbf3574..ec80a42 100644
--- a/src/mainboard/intel/baskingridge/mainboard.c
+++ b/src/mainboard/intel/baskingridge/mainboard.c
@@ -39,7 +39,7 @@
// mainboard_enable is executed as first thing after
// enumerate_buses().
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
diff --git a/src/mainboard/intel/bayleybay_fsp/mainboard.c b/src/mainboard/intel/bayleybay_fsp/mainboard.c
index ea57c93..996be0f 100644
--- a/src/mainboard/intel/bayleybay_fsp/mainboard.c
+++ b/src/mainboard/intel/bayleybay_fsp/mainboard.c
@@ -34,7 +34,7 @@
* mainboard_enable is executed as first thing after enumerate_buses().
* This is the earliest point to add customization.
*/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
}
diff --git a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c
index 393fad8..395480b 100644
--- a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c
+++ b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c
@@ -34,7 +34,7 @@
* mainboard_enable is executed as first thing after enumerate_buses().
* This is the earliest point to add customization.
*/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
}
diff --git a/src/mainboard/intel/cannonlake_rvp/mainboard.c b/src/mainboard/intel/cannonlake_rvp/mainboard.c
index 316485d..e55a151 100644
--- a/src/mainboard/intel/cannonlake_rvp/mainboard.c
+++ b/src/mainboard/intel/cannonlake_rvp/mainboard.c
@@ -32,7 +32,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- device_t device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
@@ -55,7 +55,7 @@
return end_addr;
}
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->write_acpi_tables = mainboard_write_acpi_tables;
dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
diff --git a/src/mainboard/intel/cougar_canyon2/mainboard.c b/src/mainboard/intel/cougar_canyon2/mainboard.c
index 059a315..829a962 100644
--- a/src/mainboard/intel/cougar_canyon2/mainboard.c
+++ b/src/mainboard/intel/cougar_canyon2/mainboard.c
@@ -42,7 +42,7 @@
// mainboard_enable is executed as first thing after
// enumerate_buses().
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
}
diff --git a/src/mainboard/intel/cougar_canyon2/romstage.c b/src/mainboard/intel/cougar_canyon2/romstage.c
index 96c22ea..0ac3098 100644
--- a/src/mainboard/intel/cougar_canyon2/romstage.c
+++ b/src/mainboard/intel/cougar_canyon2/romstage.c
@@ -51,7 +51,7 @@
static void pch_enable_lpc(void)
{
- device_t dev = PCH_LPC_DEV;
+ struct device *dev = PCH_LPC_DEV;
/* Set COM1/COM2 decode range */
pci_write_config16(dev, LPC_IO_DEC, 0x0010);
diff --git a/src/mainboard/intel/d510mo/mainboard.c b/src/mainboard/intel/d510mo/mainboard.c
index 4f0f32b..26d3dc1 100644
--- a/src/mainboard/intel/d510mo/mainboard.c
+++ b/src/mainboard/intel/d510mo/mainboard.c
@@ -20,7 +20,7 @@
#include <device/pci.h>
#include <drivers/intel/gma/int15.h>
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_NONE,
GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_CRT, 0);
diff --git a/src/mainboard/intel/d510mo/romstage.c b/src/mainboard/intel/d510mo/romstage.c
index b2044c1..2f65470 100644
--- a/src/mainboard/intel/d510mo/romstage.c
+++ b/src/mainboard/intel/d510mo/romstage.c
@@ -42,7 +42,7 @@
/* Early mainboard specific GPIO setup */
static void mb_gpio_init(void)
{
- device_t dev;
+ struct device *dev;
/* Southbridge GPIOs. */
dev = PCI_DEV(0x0, 0x1f, 0x0);
diff --git a/src/mainboard/intel/dcp847ske/mainboard.c b/src/mainboard/intel/dcp847ske/mainboard.c
index 5dc4ab6..1fc68fe 100644
--- a/src/mainboard/intel/dcp847ske/mainboard.c
+++ b/src/mainboard/intel/dcp847ske/mainboard.c
@@ -19,7 +19,7 @@
#include <drivers/intel/gma/int15.h>
#include <southbridge/intel/common/gpio.h>
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
printk(BIOS_DEBUG, "Memory voltage: %s\n",
get_gpio(8) ? "1.35V" : "1.5V");
diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c
index eac995a..98b474e 100644
--- a/src/mainboard/intel/emeraldlake2/chromeos.c
+++ b/src/mainboard/intel/emeraldlake2/chromeos.c
@@ -29,7 +29,7 @@
void fill_lb_gpios(struct lb_gpios *gpios)
{
- device_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
+ struct device *dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
u16 gpio_base = pci_read_config32(dev, GPIOBASE) & 0xfffe;
if (!gpio_base)
diff --git a/src/mainboard/intel/emeraldlake2/mainboard.c b/src/mainboard/intel/emeraldlake2/mainboard.c
index 654b1de..7ea1c51 100644
--- a/src/mainboard/intel/emeraldlake2/mainboard.c
+++ b/src/mainboard/intel/emeraldlake2/mainboard.c
@@ -33,7 +33,7 @@
// mainboard_enable is executed as first thing after
// enumerate_buses().
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
diff --git a/src/mainboard/intel/emeraldlake2/romstage.c b/src/mainboard/intel/emeraldlake2/romstage.c
index 24c4b56..c2ea682 100644
--- a/src/mainboard/intel/emeraldlake2/romstage.c
+++ b/src/mainboard/intel/emeraldlake2/romstage.c
@@ -42,7 +42,7 @@
void pch_enable_lpc(void)
{
- device_t dev = PCH_LPC_DEV;
+ struct device *dev = PCH_LPC_DEV;
/* Set COM1/COM2 decode range */
pci_write_config16(dev, LPC_IO_DEC, 0x0010);
diff --git a/src/mainboard/intel/galileo/gpio.c b/src/mainboard/intel/galileo/gpio.c
index 857390e..cee673d 100644
--- a/src/mainboard/intel/galileo/gpio.c
+++ b/src/mainboard/intel/galileo/gpio.c
@@ -45,7 +45,7 @@
}
}
-void mainboard_gpio_i2c_init(device_t dev)
+void mainboard_gpio_i2c_init(struct device *dev)
{
const struct reg_script *script;
diff --git a/src/mainboard/intel/glkrvp/mainboard.c b/src/mainboard/intel/glkrvp/mainboard.c
index ac5e973..ddb805a 100644
--- a/src/mainboard/intel/glkrvp/mainboard.c
+++ b/src/mainboard/intel/glkrvp/mainboard.c
@@ -42,7 +42,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- device_t device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
@@ -65,7 +65,7 @@
return end_addr;
}
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->write_acpi_tables = mainboard_write_acpi_tables;
dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
diff --git a/src/mainboard/intel/kblrvp/mainboard.c b/src/mainboard/intel/kblrvp/mainboard.c
index 652af73..8cbe264 100644
--- a/src/mainboard/intel/kblrvp/mainboard.c
+++ b/src/mainboard/intel/kblrvp/mainboard.c
@@ -26,7 +26,7 @@
#include "ec.h"
#include <variant/gpio.h>
-static void mainboard_init(device_t dev)
+static void mainboard_init(struct device *dev)
{
if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
mainboard_ec_init();
@@ -36,7 +36,7 @@
* mainboard_enable is executed as first thing after
* enumerate_buses().
*/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
diff --git a/src/mainboard/intel/kunimitsu/mainboard.c b/src/mainboard/intel/kunimitsu/mainboard.c
index cbadc2e..c87b565 100644
--- a/src/mainboard/intel/kunimitsu/mainboard.c
+++ b/src/mainboard/intel/kunimitsu/mainboard.c
@@ -29,7 +29,7 @@
static const char *oem_id_maxim = "INTEL";
static const char *oem_table_id_maxim = "SCRDMAX";
-static void mainboard_init(device_t dev)
+static void mainboard_init(struct device *dev)
{
mainboard_ec_init();
}
@@ -42,7 +42,7 @@
}
static unsigned long mainboard_write_acpi_tables(
- device_t device, unsigned long current, acpi_rsdp_t *rsdp)
+ struct device *device, unsigned long current, acpi_rsdp_t *rsdp)
{
uintptr_t start_addr;
uintptr_t end_addr;
@@ -96,7 +96,7 @@
* mainboard_enable is executed as first thing after
* enumerate_buses().
*/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
dev->ops->write_acpi_tables = mainboard_write_acpi_tables;
diff --git a/src/mainboard/intel/minnowmax/mainboard.c b/src/mainboard/intel/minnowmax/mainboard.c
index 70f96fc..0fe1259 100644
--- a/src/mainboard/intel/minnowmax/mainboard.c
+++ b/src/mainboard/intel/minnowmax/mainboard.c
@@ -21,7 +21,7 @@
* mainboard_enable is executed as first thing after enumerate_buses().
* This is the earliest point to add customization.
*/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
}
diff --git a/src/mainboard/intel/stargo2/mainboard.c b/src/mainboard/intel/stargo2/mainboard.c
index 2501941..408e49c 100644
--- a/src/mainboard/intel/stargo2/mainboard.c
+++ b/src/mainboard/intel/stargo2/mainboard.c
@@ -40,7 +40,7 @@
// mainboard_enable is executed as first thing after
// enumerate_buses().
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
}
diff --git a/src/mainboard/intel/strago/mainboard.c b/src/mainboard/intel/strago/mainboard.c
index 71ba62b..21a57cb 100644
--- a/src/mainboard/intel/strago/mainboard.c
+++ b/src/mainboard/intel/strago/mainboard.c
@@ -21,7 +21,7 @@
#include <vendorcode/google/chromeos/chromeos.h>
#include "ec.h"
-static void mainboard_init(device_t dev)
+static void mainboard_init(struct device *dev)
{
mainboard_ec_init();
}
@@ -30,7 +30,7 @@
* mainboard_enable is executed as first thing after
* enumerate_buses().
*/
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c
index ffb5b86..177eca0 100644
--- a/src/mainboard/intel/wtm2/mainboard.c
+++ b/src/mainboard/intel/wtm2/mainboard.c
@@ -38,7 +38,7 @@
// mainboard_enable is executed as first thing after
// enumerate_buses().
-static void mainboard_enable(device_t dev)
+static void mainboard_enable(struct device *dev)
{
dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
--
To view, visit https://review.coreboot.org/26090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2c466a280d18979d5f9ca182793ed43431d2010
Gerrit-Change-Number: 26090
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180504/ecad4026/attachment-0001.html>
More information about the coreboot-gerrit
mailing list