[coreboot-gerrit] Change in coreboot[master]: drivers/i2c: Add driver for rt5682 codec
Naveen Manohar (Code Review)
gerrit at coreboot.org
Fri May 4 14:49:08 CEST 2018
Naveen Manohar has uploaded this change for review. ( https://review.coreboot.org/26059
Change subject: drivers/i2c: Add driver for rt5682 codec
......................................................................
drivers/i2c: Add driver for rt5682 codec
This commit adds a new driver for the RT5682 codec to use instead
of the generic i2c driver. Since the kernel needs additional
driver-specific device properties we need a Coreboot driver that can
provide those properties.
The kernel driver devicetree properties for this codec are at:
linux/Documentation/devicetree/bindings/sound/rt5668.txt
BUG=b:79235534
TEST=With the series merged & required driver support in kernel.
Verify Headset Audio playback.
Change-Id: Ief6dd3756490d611e230bcf7785bc371d6fb37cf
Signed-off-by: Naveen Manohar <naveen.m at intel.com>
---
A src/drivers/i2c/rt5682/Kconfig
A src/drivers/i2c/rt5682/Makefile.inc
A src/drivers/i2c/rt5682/chip.h
A src/drivers/i2c/rt5682/rt5682.c
4 files changed, 145 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/26059/1
diff --git a/src/drivers/i2c/rt5682/Kconfig b/src/drivers/i2c/rt5682/Kconfig
new file mode 100644
index 0000000..030cc2e
--- /dev/null
+++ b/src/drivers/i2c/rt5682/Kconfig
@@ -0,0 +1,4 @@
+config DRIVERS_I2C_RT5682
+ bool
+ default n
+ depends on HAVE_ACPI_TABLES
diff --git a/src/drivers/i2c/rt5682/Makefile.inc b/src/drivers/i2c/rt5682/Makefile.inc
new file mode 100644
index 0000000..f8b3c12
--- /dev/null
+++ b/src/drivers/i2c/rt5682/Makefile.inc
@@ -0,0 +1 @@
+ramstage-$(CONFIG_DRIVERS_I2C_RT5682) += rt5682.c
diff --git a/src/drivers/i2c/rt5682/chip.h b/src/drivers/i2c/rt5682/chip.h
new file mode 100644
index 0000000..cf1263b
--- /dev/null
+++ b/src/drivers/i2c/rt5682/chip.h
@@ -0,0 +1,34 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+/*
+ * Realtek RT5682 audio codec devicetree bindings
+ */
+struct drivers_i2c_rt5682_config {
+ /* I2C Bus Frequency in Hertz (default 400kHz) */
+ unsigned int bus_speed;
+ /* Identifier for multiple chips */
+ unsigned int uid;
+
+ /* Allow GPIO based interrupt or PIRQ */
+ struct acpi_gpio irq_gpio;
+ struct acpi_irq irq;
+
+ /* Manual offset value to compensate DC offset for L/R channels */
+ uint32_t dc_offset_l_manual;
+ uint32_t dc_offset_r_manual;
+ uint32_t dc_offset_l_manual_mic;
+ uint32_t dc_offset_r_manual_mic;
+};
diff --git a/src/drivers/i2c/rt5682/rt5682.c b/src/drivers/i2c/rt5682/rt5682.c
new file mode 100644
index 0000000..c903dac
--- /dev/null
+++ b/src/drivers/i2c/rt5682/rt5682.c
@@ -0,0 +1,106 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <arch/acpi.h>
+#include <arch/acpi_device.h>
+#include <arch/acpigen.h>
+#include <console/console.h>
+#include <device/i2c.h>
+#include <device/device.h>
+#include <device/path.h>
+#include <stdint.h>
+#include <string.h>
+#include "chip.h"
+
+#define RT5682_ACPI_NAME "RT58"
+#define RT5682_ACPI_HID "10EC5682"
+
+#define RT5682_DP_INT(key, val) \
+ acpi_dp_add_integer(dp, "realtek," key, (val))
+
+static void rt5682_fill_ssdt(struct device *dev)
+{
+ struct drivers_i2c_rt5682_config *config = dev->chip_info;
+ const char *scope = acpi_device_scope(dev);
+ struct acpi_i2c i2c = {
+ .address = dev->path.i2c.device,
+ .mode_10bit = dev->path.i2c.mode_10bit,
+ .speed = config->bus_speed ? : I2C_SPEED_FAST,
+ .resource = scope,
+ };
+ struct acpi_dp *dp;
+
+ if (!dev->enabled || !scope)
+ return;
+
+ /* Device */
+ acpigen_write_scope(scope);
+ acpigen_write_device(acpi_device_name(dev));
+ acpigen_write_name_string("_HID", RT5682_ACPI_HID);
+ acpigen_write_name_integer("_UID", config->uid);
+ acpigen_write_name_string("_DDN", dev->chip_ops->name);
+ acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
+
+ /* Resources */
+ acpigen_write_name("_CRS");
+ acpigen_write_resourcetemplate_header();
+ acpi_device_write_i2c(&i2c);
+ /* Allow either GpioInt() or Interrupt() */
+ if (config->irq_gpio.pin_count)
+ acpi_device_write_gpio(&config->irq_gpio);
+ else
+ acpi_device_write_interrupt(&config->irq);
+ acpigen_write_resourcetemplate_footer();
+
+ /* Device Properties */
+ dp = acpi_dp_new_table("_DSD");
+ if (config->irq_gpio.pin_count)
+ acpi_dp_add_gpio(dp, "irq-gpios", acpi_device_path(dev), 0, 0,
+ config->irq_gpio.polarity == ACPI_GPIO_ACTIVE_LOW);
+ RT5682_DP_INT("dc_offset_l_manual", config->dc_offset_l_manual);
+ RT5682_DP_INT("dc_offset_r_manual", config->dc_offset_r_manual);
+ RT5682_DP_INT("dc_offset_l_manual_mic", config->dc_offset_l_manual_mic);
+ RT5682_DP_INT("dc_offset_r_manual_mic", config->dc_offset_r_manual_mic);
+ acpi_dp_write(dp);
+
+ acpigen_pop_len(); /* Device */
+ acpigen_pop_len(); /* Scope */
+
+ printk(BIOS_INFO, "%s: %s address 0%xh\n", acpi_device_path(dev),
+ dev->chip_ops->name, dev->path.i2c.device);
+}
+
+static const char *rt5682_acpi_name(const struct device *dev)
+{
+ return RT5682_ACPI_NAME;
+}
+
+static struct device_operations rt5682_ops = {
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
+ .acpi_name = &rt5682_acpi_name,
+ .acpi_fill_ssdt_generator = &rt5682_fill_ssdt,
+};
+
+static void rt5682_enable(struct device *dev)
+{
+ dev->ops = &rt5682_ops;
+}
+
+struct chip_operations drivers_i2c_rt5682_ops = {
+ CHIP_NAME("Realtek RT5682 Codec")
+ .enable_dev = &rt5682_enable
+};
--
To view, visit https://review.coreboot.org/26059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief6dd3756490d611e230bcf7785bc371d6fb37cf
Gerrit-Change-Number: 26059
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Manohar <naveen.m at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180504/03e364fc/attachment-0001.html>
More information about the coreboot-gerrit
mailing list