[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/glkrvp: Add support for rt5682 audio

Naveen Manohar (Code Review) gerrit at coreboot.org
Fri May 4 14:49:08 CEST 2018


Naveen Manohar has uploaded this change for review. ( https://review.coreboot.org/26058


Change subject: mainboard/intel/glkrvp: Add support for rt5682 audio
......................................................................

mainboard/intel/glkrvp: Add support for rt5682 audio

Patch adds the below:
1) Add correct SSP endpoint config for rt5682 headset
2) Add GPIO config for jack detection

BUG=b:79235534
TEST=sound card binds
TEST=cross checked SSDT entries from /sys/firmware/acpi/tables/
TEST=Jack interrupt works

Change-Id: Ia28bfe94c0aaa87d79f4c3565c829429792be71c
Signed-off-by: Naveen Manohar <naveen.m at intel.com>
---
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
2 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/26058/1

diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig
index 7b72412..cf5c3e4 100644
--- a/src/mainboard/intel/glkrvp/Kconfig
+++ b/src/mainboard/intel/glkrvp/Kconfig
@@ -13,6 +13,7 @@
 	select MAINBOARD_HAS_TPM2
 	select DRIVERS_GENERIC_MAX98357A
 	select DRIVERS_I2C_DA7219
+	select DRIVERS_I2C_RT5682
 	select SOC_ESPI
 
 if BOARD_INTEL_BASEBOARD_GLKRVP
diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
index 70b28bb..8dce3b2 100644
--- a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
@@ -149,6 +149,14 @@
 				register "mic_amp_in_sel" = ""diff""
 				device i2c 1a on end
 			end
+			chip drivers/i2c/generic
+				register "hid" = ""10EC5682""
+				register "name" = ""RT58""
+				register "desc" = ""Realtek RT5682""
+				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPIO_20_IRQ)"
+				register "probed" = "1"
+				device i2c 1a on end
+			end
 		end
 		device pci 16.1 off end	# - I2C 1
 		device pci 16.2 off end # - I2C 2

-- 
To view, visit https://review.coreboot.org/26058
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia28bfe94c0aaa87d79f4c3565c829429792be71c
Gerrit-Change-Number: 26058
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Manohar <naveen.m at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180504/b4c4b72a/attachment-0001.html>


More information about the coreboot-gerrit mailing list