[coreboot-gerrit] Change in coreboot[master]: device/pci_ops: Remove unnecessary weak implementation

Nico Huber (Code Review) gerrit at coreboot.org
Fri May 4 14:17:01 CEST 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26054


Change subject: device/pci_ops: Remove unnecessary weak implementation
......................................................................

device/pci_ops: Remove unnecessary weak implementation

I doubt this is or will ever be referenced anywhere. And if, we
probably shouldn't return.

Change-Id: I3704fec694c5e5a9d5ff7d78d8bf2f23cf463e3c
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/device/pci_ops.c
1 file changed, 0 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/26054/1

diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c
index 6d88209..202a9cd 100644
--- a/src/device/pci_ops.c
+++ b/src/device/pci_ops.c
@@ -20,13 +20,6 @@
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
 
-/* Overwrite with architecture specific method */
-const struct pci_bus_operations __attribute__((weak))
-*pci_bus_default_ops(struct device *dev)
-{
-	return NULL;
-}
-
 static const struct pci_bus_operations *pci_bus_ops(struct bus *bus, struct device *dev)
 {
 	const struct pci_bus_operations *bops;

-- 
To view, visit https://review.coreboot.org/26054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3704fec694c5e5a9d5ff7d78d8bf2f23cf463e3c
Gerrit-Change-Number: 26054
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180504/8bdc8eb2/attachment.html>


More information about the coreboot-gerrit mailing list