[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/basecode: Add new folder PCH for common code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/26026 )

Change subject: soc/intel/common/basecode: Add new folder PCH for common code
......................................................................


Patch Set 6:

> If your platform contains a PCH, it's technically not a SOC any
 > more. Maybe you should use src/northbridge and src/southbridge
 > instead ?

HI Pratik,

Not sure if i understood your comments. what you mean by platform contains PCH ? its 2 chip solution right, so we have PCH as we have a name for that too, so if we want to bench mark one PCH name and call it as base code its easy for us to maintain the code/.


-- 
To view, visit https://review.coreboot.org/26026
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3587d8fd69c6ac7d3d772401969258c3f3600809
Gerrit-Change-Number: 26026
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Comment-Date: Thu, 03 May 2018 12:03:36 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180503/bf2828cb/attachment.html>