[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Use common i2c support for CNL PCH

[Maulik V Vaghela (Code Review)]

Hello Subrata Banik, Balaji Manigandan, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/26030

to look at the new patch set (#5).

Change subject: soc/intel/cannonlake: Use common i2c support for CNL PCH
......................................................................

soc/intel/cannonlake: Use common i2c support for CNL PCH

In previous patch, common i2c support was added for soc which uses same
configurations as cannonlake pch. For cannonlake soc, we'll switch to common
i2c support and remove code from soc folder. This will allow us to
reduce redundant copy of common code across multiple soc.

When common i2c support is used, soc needs to implement one function for
i2c which returns soc specific configuration for the IP. This function
is implemented inside chip_config.c file which will have all the chip
specific information.

BUG=none
BRANCH=none
TEST=code compiles with different configurations. No changes in code
logic.

Change-Id: I95b3d1b2b0dfd5fb49859ddf5c42fee44b16dd8c
Signed-off-by: Maulik V Vaghela <maulik.v.vaghela at intel.com>
---
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/Makefile.inc
M src/soc/intel/cannonlake/chip_config.c
D src/soc/intel/cannonlake/i2c.c
4 files changed, 23 insertions(+), 87 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/26030/5
-- 
To view, visit https://review.coreboot.org/26030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95b3d1b2b0dfd5fb49859ddf5c42fee44b16dd8c
Gerrit-Change-Number: 26030
Gerrit-PatchSet: 5
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180503/f6d79bb2/attachment.html>