[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/basecode: Add new folder PCH for common code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/26026 )

Change subject: soc/intel/common/basecode: Add new folder PCH for common code
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/26026/3/src/soc/intel/common/basecode/include/intelbasecode/lockdown.h
File src/soc/intel/common/basecode/include/intelbasecode/lockdown.h:

https://review.coreboot.org/#/c/26026/3/src/soc/intel/common/basecode/include/intelbasecode/lockdown.h@a1
PS3, Line 1: 
why it showing deleted ?


https://review.coreboot.org/#/c/26026/3/src/soc/intel/common/basecode/pch/Kconfig
File src/soc/intel/common/basecode/pch/Kconfig:

https://review.coreboot.org/#/c/26026/3/src/soc/intel/common/basecode/pch/Kconfig@5
PS3, Line 5: CNL
Select CannonLake Point PCH base support. SoC may select this config to avail those common PCH code.



-- 
To view, visit https://review.coreboot.org/26026
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3587d8fd69c6ac7d3d772401969258c3f3600809
Gerrit-Change-Number: 26026
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 03 May 2018 10:11:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180503/ab54befc/attachment.html>