[coreboot-gerrit] Change in coreboot[master]: mainboard/google: Comment variant names in Kconfig

Martin Roth (Code Review) gerrit at coreboot.org
Thu May 3 04:48:36 CEST 2018


Martin Roth has uploaded a new patch set (#2). ( https://review.coreboot.org/26020 )

Change subject: mainboard/google: Comment variant names in Kconfig
......................................................................

mainboard/google: Comment variant names in Kconfig

It's very confusing trying to find the google platform names, because
they seem all unsorted in Kconfig.  They're actually sorted according
to the variant name, but previously, that was impossible to tell.

- Add a comment to the top of variants in Kconfig.name
- Inset each variant name.  If you start a prompt with whitespace,
it gets ignored, so after trying various ways to indent, the arrow
was the option I thought looked the best.

It now looks like this:
*** Beltino ***

->  Mccloud (Acer Chromebox CXI)

->  Monroe (LG Chromebase 22CV241 & 22CB25S)

->  Panther (ASUS Chromebox CN60)

->  Tricky (Dell Chromebox 3010)

->  Zako (HP Chromebox G1)

Butterfly (HP Pavilion Chromebook 14)

Chell (HP Chromebook 13 G1)

Cheza

*** Cyan ***

Change-Id: I35cb16b040651cd1bd0c4aef98494368ef5ca512
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/auron/Kconfig.name
M src/mainboard/google/beltino/Kconfig.name
M src/mainboard/google/cyan/Kconfig.name
M src/mainboard/google/gru/Kconfig.name
M src/mainboard/google/jecht/Kconfig.name
M src/mainboard/google/kahlee/Kconfig.name
M src/mainboard/google/oak/Kconfig.name
M src/mainboard/google/octopus/Kconfig.name
M src/mainboard/google/poppy/Kconfig.name
M src/mainboard/google/rambi/Kconfig.name
M src/mainboard/google/reef/Kconfig.name
M src/mainboard/google/slippy/Kconfig.name
M src/mainboard/google/veyron/Kconfig.name
M src/mainboard/google/zoombini/Kconfig.name
14 files changed, 108 insertions(+), 80 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/26020/2
-- 
To view, visit https://review.coreboot.org/26020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35cb16b040651cd1bd0c4aef98494368ef5ca512
Gerrit-Change-Number: 26020
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180503/0efdbbb6/attachment.html>


More information about the coreboot-gerrit mailing list