[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/atlas: update DMIC NHLT configuration
Sathyanarayana Nujella (Code Review)
gerrit at coreboot.org
Thu May 3 03:38:42 CEST 2018
Sathyanarayana Nujella has uploaded this change for review. ( https://review.coreboot.org/26019
Change subject: mb/google/poppy/variants/atlas: update DMIC NHLT configuration
......................................................................
mb/google/poppy/variants/atlas: update DMIC NHLT configuration
>From coreboot side, include DMIC 4ch NHLT configuration and its
DMIC blob. In OS side, cras picks the needed channels using UCM's
channel map configuration.
So, this patch updates to include DMIC 4ch config.
BUG=b:79158926
TEST=verified 4-ch record with arecord
TEST=Also verified internal mic record with cras using
'cras_test_client --capture_file dmic.raw --rate 48000 --num_channels 2 --duration 10'
Change-Id: Ic6df00c2f26ad9cdf54152ab021c2b10499c429c
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/variants/atlas/nhlt.c
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/26019/1
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 8cd636d..37751f4 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -64,7 +64,7 @@
config INCLUDE_NHLT_BLOBS_ATLAS
bool "Include blobs for atlas audio."
select NHLT_DA7219
- select NHLT_DMIC_2CH
+ select NHLT_DMIC_4CH
select NHLT_MAX98373
config INCLUDE_NHLT_BLOBS_NAUTILUS
diff --git a/src/mainboard/google/poppy/variants/atlas/nhlt.c b/src/mainboard/google/poppy/variants/atlas/nhlt.c
index df62112..4d0fd1e 100644
--- a/src/mainboard/google/poppy/variants/atlas/nhlt.c
+++ b/src/mainboard/google/poppy/variants/atlas/nhlt.c
@@ -20,9 +20,9 @@
void variant_nhlt_init(struct nhlt *nhlt)
{
- /* 2 Channel DMIC array. */
- if (nhlt_soc_add_dmic_array(nhlt, 2))
- printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n");
+ /* 4 Channel DMIC array. */
+ if (nhlt_soc_add_dmic_array(nhlt, 4))
+ printk(BIOS_ERR, "Couldn't add 4CH DMIC arrays.\n");
/* Dialog DA7219 Headset codec. */
if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))
--
To view, visit https://review.coreboot.org/26019
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6df00c2f26ad9cdf54152ab021c2b10499c429c
Gerrit-Change-Number: 26019
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180503/bb56e063/attachment.html>
More information about the coreboot-gerrit
mailing list