[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode

Martin Roth (Code Review) gerrit at coreboot.org
Wed May 2 22:49:24 CEST 2018


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/25970 )

Change subject: google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode
......................................................................

google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode

Set SPI Fast Read to 100MHz and Dual Read IO mode to speed up
the boot process by over a half second. Also, increase the Normal
Read speed to 33MHz as supported by the W25Q128FW.

BUG=b:70558952
TEST=Run cbmem -t to get boot times.

Change-Id: I616a96526ed90bb4ab0c9c6b78787799faa02633
Signed-off-by: Marc Jones <marc.jones at scarletltd.com>
Reviewed-on: https://review.coreboot.org/25970
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/bootblock/bootblock.c
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Marshall Dawson: Looks good to me, approved



diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c
index 577c105..aac1d95 100644
--- a/src/mainboard/google/kahlee/bootblock/bootblock.c
+++ b/src/mainboard/google/kahlee/bootblock/bootblock.c
@@ -34,9 +34,17 @@
 
 void bootblock_mainboard_init(void)
 {
+	/*
+	 * W25Q128FW Setup
+	 * Normal Read 40MHz
+	 * Fast Read 104MHz
+	 * Dual Read IO (1-2-2)
+	 */
+	sb_read_mode(SPI_READ_MODE_DUAL122);
+
 	/* Set SPI speeds before verstage. Needed for TPM */
-	sb_set_spi100(SPI_SPEED_22M,		/* Normal */
-			SPI_SPEED_66M,		/* Fast   */
+	sb_set_spi100(SPI_SPEED_33M,		/* Normal */
+			SPI_SPEED_100M,		/* Fast   */
 			SPI_SPEED_66M,		/* AltIO  */
 			SPI_SPEED_66M);		/* TPM    */
 

-- 
To view, visit https://review.coreboot.org/25970
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I616a96526ed90bb4ab0c9c6b78787799faa02633
Gerrit-Change-Number: 25970
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180502/7ceb7995/attachment.html>


More information about the coreboot-gerrit mailing list