[coreboot-gerrit] Change in coreboot[master]: mainboard/google/reef: Remove tablet mode switch support

Martin Roth (Code Review) gerrit at coreboot.org
Wed May 2 16:20:56 CEST 2018


Martin Roth has posted comments on this change. ( https://review.coreboot.org/25982 )

Change subject: mainboard/google/reef: Remove tablet mode switch support
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25982/1/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
File src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h:

https://review.coreboot.org/#/c/25982/1/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h@a37
PS1, Line 37: 
> Why is this removed?
I was reverting the commit where the tablet switch event was added.

https://review.coreboot.org/#/c/coreboot/+/18277/2/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h



-- 
To view, visit https://review.coreboot.org/25982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116
Gerrit-Change-Number: 25982
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Wed, 02 May 2018 14:20:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180502/dafc5c00/attachment.html>


More information about the coreboot-gerrit mailing list