[coreboot-gerrit] Change in coreboot[master]: board_status: Remove sudo when checking for cbmem with command

Matthias Gazzari (Code Review) gerrit at coreboot.org
Wed May 2 15:52:59 CEST 2018


Matthias Gazzari has uploaded this change for review. ( https://review.coreboot.org/25989


Change subject: board_status: Remove sudo when checking for cbmem with command
......................................................................

board_status: Remove sudo when checking for cbmem with command

I get the error below when using the following command in combination
with sudo:

sudo command -v $SOME_COMMAND
sudo: command: command not found

Detection of the cbmem path is working fine without sudo.

Change-Id: I8788c190ffebde117e2abd3df924c48d8f6fd05d
Signed-off-by: Matthias Gazzari <mail at qtux.eu>
---
M util/board_status/board_status.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/25989/1

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index ca7e2c7..b60ef75 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -378,7 +378,7 @@
 else
 	echo "Verifying that CBMEM is available"
 	if [ $(id -u) -ne 0 ]; then
-		sudo command -v "$cbmem_cmd" >/dev/null
+		command -v "$cbmem_cmd" >/dev/null
 		if [ $? -ne 0 ]; then
 			echo "Failed to run $cbmem_cmd using sudo. Check \$PATH or use -c" \
 			"to specify path to cbmem binary."

-- 
To view, visit https://review.coreboot.org/25989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8788c190ffebde117e2abd3df924c48d8f6fd05d
Gerrit-Change-Number: 25989
Gerrit-PatchSet: 1
Gerrit-Owner: Matthias Gazzari <mail at qtux.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180502/34ec26b5/attachment.html>


More information about the coreboot-gerrit mailing list