[coreboot-gerrit] Change in coreboot[master]: amd/common/block/pi: Make agesa_heap_base() static

Marshall Dawson (Code Review) gerrit at coreboot.org
Fri Mar 30 00:24:33 CEST 2018


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/25457 )

Change subject: amd/common/block/pi: Make agesa_heap_base() static
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25457/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25457/1//COMMIT_MSG@11
PS1, Line 11: 
            : C
> Is there a bug associated to? Maybe this is a small patch for something else that does have a bug nu […]
No bug since it's not particularly google-specific.  I'm not even crazy about putting in test= as this is change is somewhat self-evident, and just adheres to good source hygiene.  Any resulting ROM image is unchanged by this patch.



-- 
To view, visit https://review.coreboot.org/25457
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ee162985ca1ea36461ea413416d98451a700f8c
Gerrit-Change-Number: 25457
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 29 Mar 2018 22:24:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180329/82eb5819/attachment.html>


More information about the coreboot-gerrit mailing list