[coreboot-gerrit] Change in coreboot[master]: soc/intel/denverton_ns: Use cpulib in cpu.c

Julien Viard de Galbert (Code Review) gerrit at coreboot.org
Thu Mar 29 15:07:58 CEST 2018


Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/25432


Change subject: soc/intel/denverton_ns: Use cpulib in cpu.c
......................................................................

soc/intel/denverton_ns: Use cpulib in cpu.c

Also remove duplicate code

Change-Id: I45da6363a35cf6f5855906bb97ed023681d36df7
Signed-off-by: Julien Viard de Galbert <jviarddegalbert at online.net>
---
M src/soc/intel/denverton_ns/cpu.c
1 file changed, 1 insertion(+), 9 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/25432/1

diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c
index fba6627..12fda1c 100644
--- a/src/soc/intel/denverton_ns/cpu.c
+++ b/src/soc/intel/denverton_ns/cpu.c
@@ -24,6 +24,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci.h>
+#include <intelblocks/cpulib.h>
 #include <reg_script.h>
 
 #include <soc/msr.h>
@@ -175,15 +176,6 @@
 	return num_cpus;
 }
 
-static int cpu_config_tdp_levels(void)
-{
-	msr_t platform_info;
-
-	/* Bits 34:33 indicate how many levels supported */
-	platform_info = rdmsr(MSR_PLATFORM_INFO);
-	return (platform_info.hi >> 1) & 3;
-}
-
 static void set_max_turbo_freq(void)
 {
 	msr_t msr, perf_ctl;

-- 
To view, visit https://review.coreboot.org/25432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45da6363a35cf6f5855906bb97ed023681d36df7
Gerrit-Change-Number: 25432
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180329/608da65d/attachment-0001.html>


More information about the coreboot-gerrit mailing list