[coreboot-gerrit] Change in coreboot[master]: src/include/hexutil.h: Add converters for working with hex strings

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/25411 )

Change subject: src/include/hexutil.h: Add converters for working with hex strings
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/25411/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25411/1//COMMIT_MSG@12
PS1, Line 12: I have a bunch of unit tests for these functions outside of this commit. Is
            : there somewhere I can commit them?
This does not belong here. That said, you can start the title with [Not-for-merge] and commit them to coreboot.


https://review.coreboot.org/#/c/25411/1//COMMIT_MSG@16
PS1, Line 16: tested on grunt
Say something like: "Build and boot grunt. Tested with functions that are part of a separate commit." or "Build and boot grunt. Used debug tests to test the functions, removed before committing."


https://review.coreboot.org/#/c/25411/1/src/include/hexutil.h
File src/include/hexutil.h:

https://review.coreboot.org/#/c/25411/1/src/include/hexutil.h@26
PS1, Line 26:  * */
*/


https://review.coreboot.org/#/c/25411/1/src/lib/hexutil.c
File src/lib/hexutil.c:

https://review.coreboot.org/#/c/25411/1/src/lib/hexutil.c@35
PS1, Line 35: 
What would happen if (src_size - 1) > (dest_size * 2)? You should add some code to trim src_size to fall within the limits imposed by dest_size.


https://review.coreboot.org/#/c/25411/1/src/lib/hexutil.c@59
PS1, Line 59: 
What would happen if dest_size <= (src_size * 2)? You should add some code to trim src_size to fall within the limits imposed by dest_size.



-- 
To view, visit https://review.coreboot.org/25411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcabf09be4dc053f8b6e132b4014380cdb5c521b
Gerrit-Change-Number: 25411
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 29 Mar 2018 00:06:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180329/23def83a/attachment.html>