[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Add variant for Atlas

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/25389 )

Change subject: mb/google/poppy: Add variant for Atlas
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25389/1/src/mainboard/google/poppy/variants/atlas/devicetree.cb
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:

https://review.coreboot.org/#/c/25389/1/src/mainboard/google/poppy/variants/atlas/devicetree.cb@8
PS1, Line 8: DSX_EN_WAKE_PIN
> Do we still need this? I thought we removed the wake line going to WAKE# pin.
it is still connected on atlas, though maybe it should be using a different pin for s0ix to work properly?  I will check.

Since we aren't using DS3 these probably don't need to be enabled as wake pins anyway..



-- 
To view, visit https://review.coreboot.org/25389
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0bccd1bda0134aa51885ac2c6e7bb5b45de924
Gerrit-Change-Number: 25389
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:10:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180327/0e676bb9/attachment.html>