[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: update SSP port to enable audio

Hannah Williams (Code Review) gerrit at coreboot.org
Tue Mar 27 18:27:46 CEST 2018


Hello Naveen Manohar,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25387

to review the following change.


Change subject: mb/google/octopus: update SSP port to enable audio
......................................................................

mb/google/octopus: update SSP port to enable audio

Patch corrects the SSP configuration to enable audio on GLK boards.

Change-Id: I101ed80f4421925120116b018424ef19d95a2a3a
Signed-off-by: Naveen Manohar <naveen.m at intel.com>
---
M src/mainboard/google/octopus/variants/baseboard/nhlt.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/25387/1

diff --git a/src/mainboard/google/octopus/variants/baseboard/nhlt.c b/src/mainboard/google/octopus/variants/baseboard/nhlt.c
index 7439b73..c936198 100644
--- a/src/mainboard/google/octopus/variants/baseboard/nhlt.c
+++ b/src/mainboard/google/octopus/variants/baseboard/nhlt.c
@@ -28,10 +28,10 @@
 	 * Headset codec is bi-directional but uses the same configuration
 	 * settings for render and capture endpoints.
 	 */
-	if (!nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))
+	if (!nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP2))
 		printk(BIOS_ERR, "Added Dialog_7219 codec.\n");
 
 	/* MAXIM Smart Amps for left and right speakers. */
-	if (!nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP5))
+	if (!nhlt_soc_add_max98357(nhlt, AUDIO_LINK_SSP1))
 		printk(BIOS_ERR, "Added Maxim_98357 codec.\n");
 }

-- 
To view, visit https://review.coreboot.org/25387
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I101ed80f4421925120116b018424ef19d95a2a3a
Gerrit-Change-Number: 25387
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Naveen Manohar <naveen.m at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180327/aaea6bbd/attachment-0001.html>


More information about the coreboot-gerrit mailing list