[coreboot-gerrit] Change in coreboot[master]: Revert "mb/google/nautilus: Work around the power issue of MIPI and USB"

Andy Yeh (Code Review) gerrit at coreboot.org
Mon Mar 26 16:12:26 CEST 2018


Andy Yeh has uploaded this change for review. ( https://review.coreboot.org/25369


Change subject: Revert "mb/google/nautilus: Work around the power issue of MIPI and USB"
......................................................................

Revert "mb/google/nautilus: Work around the power issue of MIPI and USB"

This reverts commit c4f94b1a7514b58388d347e79575b547eb82d08f. As the latest
Nautilus sku has the fix that the power sources for MIPI and USB camera
are supplied individually.

Bug=b:72839352
TEST=Test MIPI and USB camera on the latest Natilus sku.

Change-Id: Iac206b0ff3b038558ae5290c9d982e4bef5f17fd
Signed-off-by: Andy Yeh <andy.yeh at intel.com>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/25369/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
index 5eaf5b7..b74fba9 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
@@ -39,7 +39,14 @@
 		Method (PMOF, 0, Serialized) {
 			/* Make Sure all PMIC outputs are off. */
 			If (LEqual (VSIC, Zero)) {
+			/*
+			 * On Nautilus Pre-EVT/EVT, the USB and MIPI share the
+			 * same power source, before HW fix in DVT, temporarily
+			 * disabled turn off 3V3_VDD
+			 */
+#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)
 				CTXS(EN_PP3300_DX_CAM)
+#endif
 			}
 		}
 

-- 
To view, visit https://review.coreboot.org/25369
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac206b0ff3b038558ae5290c9d982e4bef5f17fd
Gerrit-Change-Number: 25369
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Yeh <andy.yeh at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180326/6325bf20/attachment.html>


More information about the coreboot-gerrit mailing list