[coreboot-gerrit] Change in coreboot[master]: purism/librem_skl: Add AC/DC LoadLine to VR Config

Matt DeVillier (Code Review) gerrit at coreboot.org
Thu Mar 22 23:36:08 CET 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/25324

to look at the new patch set (#2).

Change subject: purism/librem_skl: Add AC/DC LoadLine to VR Config
......................................................................

purism/librem_skl: Add AC/DC LoadLine to VR Config

The FSP 2.0 needs to set the ac_loadline and dc_loadline for
each VR config. Without it, the Loadline is considered to be
0 mOhm and this causes CPU temp to jump all over the place
whenever the CPU is used.

This is necessary since there are no VR_CONFIG icc mappings for
Skylake SKUs, only KabyLake.

These values were copied from the Google Poppy devicetree.

Change-Id: I6aeb6ee521988b94f2ae94a60d1a28b87ba984d4
Signed-off-by: Youness Alaoui <youness.alaoui at puri.sm>
---
M src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb
M src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb
2 files changed, 50 insertions(+), 30 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/25324/2
-- 
To view, visit https://review.coreboot.org/25324
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6aeb6ee521988b94f2ae94a60d1a28b87ba984d4
Gerrit-Change-Number: 25324
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180322/f721e830/attachment.html>


More information about the coreboot-gerrit mailing list