[coreboot-gerrit] Change in coreboot[master]: util/ifdtool: Fix region access control for SKL/KBL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25306 )

Change subject: util/ifdtool: Fix region access control for SKL/KBL
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:

https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c@829
PS1, Line 829: PLATFORM_SKLKBL
> How about putting different entries as below for SKL and KBL considering different variants like SKL […]
Are the values different for each variant?



-- 
To view, visit https://review.coreboot.org/25306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3
Gerrit-Change-Number: 25306
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 18:13:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180321/e50b0b07/attachment.html>