[coreboot-gerrit] Change in coreboot[master]: mb/google/zoombini: always report EC is in RO mode

Nick Vaccaro (Code Review) gerrit at coreboot.org
Tue Mar 20 17:05:58 CET 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/25298


Change subject: mb/google/zoombini: always report EC is in RO mode
......................................................................

mb/google/zoombini: always report EC is in RO mode

Always report that EC is in RO mode.  This is a temporary workaround
for a hardware issue that is causing EC to appear to be in RW mode
when it is not.  This change will be reverted once transition is made
to newer hardware.

BUG=b:74215817
BRANCH=master
TEST=Verify meowth can boot to recovery's insert screen.

Change-Id: Ib3705bba0bb1f351da79e599566fbffab94428f3
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/zoombini/chromeos.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/25298/1

diff --git a/src/mainboard/google/zoombini/chromeos.c b/src/mainboard/google/zoombini/chromeos.c
index 8ca643e..4a4ad35 100644
--- a/src/mainboard/google/zoombini/chromeos.c
+++ b/src/mainboard/google/zoombini/chromeos.c
@@ -29,8 +29,7 @@
 		{-1, ACTIVE_HIGH, get_lid_switch(), "lid"},
 		{-1, ACTIVE_HIGH, 0, "power"},
 		{-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"},
-		{GPIO_EC_IN_RW, ACTIVE_HIGH, gpio_get(GPIO_EC_IN_RW),
-		 "EC in RW"},
+		{GPIO_EC_IN_RW, ACTIVE_HIGH, 0, "EC in RW"},
 	};
 	lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
 }

-- 
To view, visit https://review.coreboot.org/25298
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3705bba0bb1f351da79e599566fbffab94428f3
Gerrit-Change-Number: 25298
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180320/995756c5/attachment-0001.html>


More information about the coreboot-gerrit mailing list