[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t

[Zhuohao Lee (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/25252

to look at the new patch set (#2).

Change subject: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t
......................................................................

mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t

Tools/scripts, like mosys/arc-setup, use int(4 bytes) to
read the sku id. In order to support "-1", we need to use
uint32_t(4 bytes) instead of using uint16_t(2 bytes) data type.
Otherwise, tools/scripts will read 65535 instead of -1.
Another reason to change this is that sku_id can be
supported by ec up to 4 bytes.

BUG=b:73792190
TEST=mosys output "Platform not Supported" for -1 sku id
     arc-setup read -1 sku id

Change-Id: Ib3baa8419f138abeb412ac09c2e7dc608e3b758b
Signed-off-by: Zhuohao Lee <zhuohao at chromium.org>
---
M src/mainboard/google/poppy/variants/nami/mainboard.c
1 file changed, 9 insertions(+), 7 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/25252/2
-- 
To view, visit https://review.coreboot.org/25252
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3baa8419f138abeb412ac09c2e7dc608e3b758b
Gerrit-Change-Number: 25252
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180316/075ef194/attachment.html>