[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/coffeelake_rvp: Enable USB2_P7 and USB2_P8

Kin Wai Ng (Code Review) gerrit at coreboot.org
Fri Mar 16 14:31:13 CET 2018


Hello Naresh Solanki, Subrata Banik, Balaji Manigandan, Aamir Bohra, Maulik V Vaghela, Rizwan Qureshi,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25242

to review the following change.


Change subject: mainboard/intel/coffeelake_rvp: Enable USB2_P7 and USB2_P8
......................................................................

mainboard/intel/coffeelake_rvp: Enable USB2_P7 and USB2_P8

Reference to schematic on CFL-H RVP11:
Connector JA4A1 to USB2_P7 and USB2_P8

Change-Id: If656d19493cea6b18a2444feb09deaba8d6e67ad
Signed-off-by: Ng Kin Wai <kin.wai.ng at intel.com>
---
M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/25242/1

diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb
index 2db1d07..c752258 100755
--- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb
+++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb
@@ -19,8 +19,8 @@
 	register "usb2_ports[3]" = "USB2_PORT_MID(OC0)"
 	register "usb2_ports[4]" = "USB2_PORT_MID(OC0)"
 	register "usb2_ports[5]" = "USB2_PORT_MID(OC0)"
-	register "usb2_ports[6]" = "USB2_PORT_EMPTY"
-	register "usb2_ports[7]" = "USB2_PORT_EMPTY"
+	register "usb2_ports[6]" = "USB2_PORT_MID(OC0)"
+	register "usb2_ports[7]" = "USB2_PORT_MID(OC0)"
 	register "usb2_ports[8]" = "USB2_PORT_EMPTY"
 	register "usb2_ports[9]" = "USB2_PORT_MID(OC0)"
 	register "usb2_ports[11]" = "USB2_PORT_MID(OC0)"

-- 
To view, visit https://review.coreboot.org/25242
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If656d19493cea6b18a2444feb09deaba8d6e67ad
Gerrit-Change-Number: 25242
Gerrit-PatchSet: 1
Gerrit-Owner: Kin Wai Ng <kin.wai.ng at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180316/ad10ba75/attachment-0001.html>


More information about the coreboot-gerrit mailing list