[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/coffeelake_rvp: Fix PID_ITSS value

Kin Wai Ng (Code Review) gerrit at coreboot.org
Fri Mar 16 14:31:06 CET 2018


Hello Naresh Solanki, Subrata Banik, Balaji Manigandan, Aamir Bohra, Maulik V Vaghela, Rizwan Qureshi,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25233

to review the following change.


Change subject: mainboard/intel/coffeelake_rvp: Fix PID_ITSS value
......................................................................

mainboard/intel/coffeelake_rvp: Fix PID_ITSS value

According to BIOS, it should be PID_ITSS=0xc4.

Change-Id: I7167b7d5419de57d266e1f33de5d39a2371e0120
Signed-off-by: Ng Kin Wai <kin.wai.ng at intel.com>
---
M src/soc/intel/coffeelake/include/soc/pcr_ids.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/25233/1

diff --git a/src/soc/intel/coffeelake/include/soc/pcr_ids.h b/src/soc/intel/coffeelake/include/soc/pcr_ids.h
old mode 100644
new mode 100755
index 09c2445..029ba2b
--- a/src/soc/intel/coffeelake/include/soc/pcr_ids.h
+++ b/src/soc/intel/coffeelake/include/soc/pcr_ids.h
@@ -35,7 +35,7 @@
 #define PID_PSF4	0xbd
 #define PID_SCS		0xc0
 #define PID_RTC		0xc3
-#define PID_ITSS	0xc2
+#define PID_ITSS	0xc4
 #define PID_LPC		0xc7
 #define PID_SERIALIO	0xcb
 

-- 
To view, visit https://review.coreboot.org/25233
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7167b7d5419de57d266e1f33de5d39a2371e0120
Gerrit-Change-Number: 25233
Gerrit-PatchSet: 1
Gerrit-Owner: Kin Wai Ng <kin.wai.ng at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180316/d80c82bb/attachment-0001.html>


More information about the coreboot-gerrit mailing list