[coreboot-gerrit] Change in coreboot[master]: soc/intel/coffeelake: Modify PCR ID for ABASE address for Coffeelake-H

Kin Wai Ng (Code Review) gerrit at coreboot.org
Fri Mar 16 14:31:03 CET 2018


Hello Naresh Solanki, Subrata Banik, Balaji Manigandan, Aamir Bohra, Maulik V Vaghela, Rizwan Qureshi,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25227

to review the following change.


Change subject: soc/intel/coffeelake: Modify PCR ID for ABASE address for Coffeelake-H
......................................................................

soc/intel/coffeelake: Modify PCR ID for ABASE address for Coffeelake-H

Change-Id: Id5eb310d8a8b4771461a9a9cae178bcdaa9ee743
Signed-off-by: Ng Kin Wai <kin.wai.ng at intel.com>
---
M src/soc/intel/coffeelake/bootblock/pch.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/25227/1

diff --git a/src/soc/intel/coffeelake/bootblock/pch.c b/src/soc/intel/coffeelake/bootblock/pch.c
old mode 100644
new mode 100755
index df7ed1a..06de746
--- a/src/soc/intel/coffeelake/bootblock/pch.c
+++ b/src/soc/intel/coffeelake/bootblock/pch.c
@@ -31,7 +31,7 @@
 #include <soc/pm.h>
 #include <soc/smbus.h>
 
-#define PCR_PSF3_TO_SHDW_PMC_REG_BASE	0x1400
+#define PCR_PSF3_TO_SHDW_PMC_REG_BASE	0x0980
 #define PCR_PSFX_TO_SHDW_BAR0	0
 #define PCR_PSFX_TO_SHDW_BAR1	0x4
 #define PCR_PSFX_TO_SHDW_BAR2	0x8

-- 
To view, visit https://review.coreboot.org/25227
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5eb310d8a8b4771461a9a9cae178bcdaa9ee743
Gerrit-Change-Number: 25227
Gerrit-PatchSet: 1
Gerrit-Owner: Kin Wai Ng <kin.wai.ng at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180316/54822394/attachment-0001.html>


More information about the coreboot-gerrit mailing list