[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: Update DPTF parameters

Duncan Laurie (Code Review) gerrit at coreboot.org
Wed Mar 14 17:17:34 CET 2018


Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/25153


Change subject: mb/google/eve: Update DPTF parameters
......................................................................

mb/google/eve: Update DPTF parameters

1) Set the critical temperature threshold to 100C to match changes
on other boards.  This is intended to reduce DPTF-initiated thermal
shutdowns before it has had a chance to react.

2) Reduce the CPU passive threshold sample rate from 5 seconds to 1
second so DPTF will react faster to rapid temperature increases.

BUG=b:67459049
BRANCH=eve
TEST=manual performance/power testing on Eve hardware

Change-Id: Ib660dcb25422fea0aa692fac5ba65b49808965ba
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/eve/acpi/dptf.asl
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/25153/1

diff --git a/src/mainboard/google/eve/acpi/dptf.asl b/src/mainboard/google/eve/acpi/dptf.asl
index 8937ee9..7dd4249 100644
--- a/src/mainboard/google/eve/acpi/dptf.asl
+++ b/src/mainboard/google/eve/acpi/dptf.asl
@@ -15,7 +15,7 @@
  */
 
 #define DPTF_CPU_PASSIVE	80
-#define DPTF_CPU_CRITICAL	99
+#define DPTF_CPU_CRITICAL	100
 
 #define DPTF_TSR0_SENSOR_ID	1
 #define DPTF_TSR0_SENSOR_NAME	"Ambient"
@@ -50,7 +50,7 @@
 
 Name (DTRT, Package () {
 	/* CPU Throttle Effect on CPU */
-	Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 50, 0, 0, 0, 0 },
+	Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 10, 0, 0, 0, 0 },
 
 	/* CPU Effect on Ambient */
 	Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR0, 100, 600, 0, 0, 0, 0 },

-- 
To view, visit https://review.coreboot.org/25153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib660dcb25422fea0aa692fac5ba65b49808965ba
Gerrit-Change-Number: 25153
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180314/baeda091/attachment.html>


More information about the coreboot-gerrit mailing list