[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init: Print amount of time it takes in bsp_do_flight_plan

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu Mar 8 08:27:52 CET 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25044


Change subject: cpu/x86/mp_init: Print amount of time it takes in bsp_do_flight_plan
......................................................................

cpu/x86/mp_init: Print amount of time it takes in bsp_do_flight_plan

Since the timeout in bsp_do_flight_plan is bumped up to 1 second, this
change adds a print to indicate the amount of time it took for all the
APs to check-in.

TEST=Verified on Nami that it prints:
"bsp_do_flight_plan done after 395 msecs."

Change-Id: I4c8380e94305ed58453ed18b341b3b923949d7a8
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/cpu/x86/mp_init.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/25044/1

diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index 23aea14..409caa5 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -547,6 +547,9 @@
 	const int timeout_us = 1000000;
 	const int step_us = 100;
 	int num_aps = mp_params->num_cpus - 1;
+	struct stopwatch sw;
+
+	stopwatch_init(&sw);
 
 	for (i = 0; i < mp_params->num_records; i++) {
 		struct mp_flight_record *rec = &mp_params->flight_plan[i];
@@ -566,6 +569,9 @@
 
 		release_barrier(&rec->barrier);
 	}
+
+	printk(BIOS_INFO, "%s done after %ld msecs.\n", __func__,
+	       stopwatch_duration_msecs(&sw));
 	return ret;
 }
 

-- 
To view, visit https://review.coreboot.org/25044
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c8380e94305ed58453ed18b341b3b923949d7a8
Gerrit-Change-Number: 25044
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180308/f5ed977c/attachment.html>


More information about the coreboot-gerrit mailing list