[coreboot-gerrit] Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software

Brian Norris (Code Review) gerrit at coreboot.org
Thu Mar 8 03:31:21 CET 2018


Hello Lin Huang, Julius Werner, build bot (Jenkins), Matthias Kaehlcke, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/25023

to look at the new patch set (#3).

Change subject: google/scarlet: Adjust K&D power sequence from software
......................................................................

google/scarlet: Adjust K&D power sequence from software

Hardware updates have suggested we need to configure the K&D panel's
power sequence in software, not in hardware. Without this change, K&D
panels will no longer power on correctly and will instead display a
black screen.

Per K&D's suggestion, we tweak these two commands. From the little HW
docs I have, this looks like it's:

(Address 0xB7, Value 0x02) -> set BC_CTRL=bit(1) (Back light control) to
                              1
(Address 0xF1, Value 0x22) -> change GPO2_SEL=bits(0:3) from
                              MIPI_TE(0001b) to BC_CTRL (0010b)

BRANCH=scarlet
BUG=b:73133861
TEST=KD display with and without HW fix on Scarlet

Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6
Signed-off-by: Brian Norris <briannorris at chromium.org>
---
M src/mainboard/google/gru/mainboard.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/25023/3
-- 
To view, visit https://review.coreboot.org/25023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6
Gerrit-Change-Number: 25023
Gerrit-PatchSet: 3
Gerrit-Owner: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Matthias Kaehlcke <mka at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180308/2f58fb99/attachment.html>


More information about the coreboot-gerrit mailing list