[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/25028 )

Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants/nami/mainboard.c
File src/mainboard/google/poppy/variants/nami/mainboard.c:

https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants/nami/mainboard.c@72
PS1, Line 72: 8
> Don't you need this to be 9?
Oh sorry.  I forgot the null termination.  Thanks.



-- 
To view, visit https://review.coreboot.org/25028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba
Gerrit-Change-Number: 25028
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 23:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180307/d19e401b/attachment.html>