[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...

Shelley Chen (Code Review) gerrit at coreboot.org
Thu Mar 8 00:48:52 CET 2018


Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/25028


Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs
......................................................................

mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs

Return proper SKU IDs so that mosys can return the proper variant.

BUG=b:74059798
BRANCH=None
TEST=./util/abuild/abuild -p none -t google/poppy -x -a

Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba
Signed-off-by: Shelley Chen <shchen at chromium.org>
---
M src/mainboard/google/poppy/variants/nami/mainboard.c
1 file changed, 13 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/25028/1

diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c
index 0f2dc9b..44b952f 100644
--- a/src/mainboard/google/poppy/variants/nami/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c
@@ -14,12 +14,14 @@
  */
 
 #include <arch/cpu.h>
+#include <assert.h>
+#include <baseboard/variants.h>
 #include <chip.h>
 #include <device/device.h>
-#include <assert.h>
 #include <ec/google/chromeec/ec.h>
+#include <smbios.h>
 #include <soc/ramstage.h>
-#include <baseboard/variants.h>
+#include <string.h>
 
 #define SKU_0_Nami	0x3A7B
 #define SKU_1_Vayne	0x3A63
@@ -64,3 +66,12 @@
 		break;
 	}
 }
+
+const char *smbios_mainboard_sku(void)
+{
+	static char sku_str[8]; /* sku{0..65535} (basically up to FFFF) */
+
+	snprintf(sku_str, sizeof(sku_str), "sku%d", board_sku_id());
+
+	return sku_str;
+}

-- 
To view, visit https://review.coreboot.org/25028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba
Gerrit-Change-Number: 25028
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180307/c2230065/attachment-0001.html>


More information about the coreboot-gerrit mailing list