[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Add WACOM EMR support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/24997 )

Change subject: mb/google/poppy/variants/nami: Add WACOM EMR support
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/nami/devicetree.cb
File src/mainboard/google/poppy/variants/nami/devicetree.cb:

https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/nami/devicetree.cb@277
PS1, Line 277: GPP_D2
This is not the pen power enable gpio. It is the detect pin.


https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/nami/gpio.c
File src/mainboard/google/poppy/variants/nami/gpio.c:

https://review.coreboot.org/#/c/24997/1/src/mainboard/google/poppy/variants/nami/gpio.c@170
PS1, Line 170: 1
Why do you need to take it out of reset here? It should be done by the power resource that you have added in ACPI.



-- 
To view, visit https://review.coreboot.org/24997
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbe809a48959e5749262aeb1b89b09c4bdafbbc2
Gerrit-Change-Number: 24997
Gerrit-PatchSet: 1
Gerrit-Owner: Jasper Lee <jasper_lee at compal.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jasper Lee <jasper_lee at compal.com>
Gerrit-Reviewer: Jimmy M Wang <jimmym_wang at compal.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Van Chen <van_chen at compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Mar 2018 15:07:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180305/eb05ab4b/attachment.html>