[coreboot-gerrit] Change in coreboot[master]: drivers/tpm: Add TPM ramstage driver for devices without vboot.

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24905 )

Change subject: drivers/tpm: Add TPM ramstage driver for devices without vboot.
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/24905/5/src/drivers/tpm/tpm.c
File src/drivers/tpm/tpm.c:

https://review.coreboot.org/#/c/24905/5/src/drivers/tpm/tpm.c@35
PS5, Line 35: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_ENTRY, init_tpm_dev, NULL);
> why not use chip_operations like it's done in drivers/pc80/tpm/tis.c ? […]
Yes. No PCI device tree, no chip operations ;)



-- 
To view, visit https://review.coreboot.org/24905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7536c9734732aeaa85ccc7916c12eecb9ca26b2e
Gerrit-Change-Number: 24905
Gerrit-PatchSet: 5
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Thu, 01 Mar 2018 18:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180301/08fad77b/attachment.html>