[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Fix conflicting OIC register definition

Nico Huber (Code Review) gerrit at coreboot.org
Thu Mar 1 13:46:40 CET 2018


Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/24924

to look at the new patch set (#2).

Change subject: sb/intel/common: Fix conflicting OIC register definition
......................................................................

sb/intel/common: Fix conflicting OIC register definition

Commit d2d2aef6a3 (sb/intel/{bd82x6,ibexpeak}: Move RCBA macros to a
common location) makes some platforms use the wrong OIC register defi-
nition. It was extended to 16-bit in the corporate version of ICH10.
So let's give the new size and location a new name: EOIC (extended OIC).

This only touches the systems affected by the mentioned change. Other
platforms still need to be adapted before they can use the common RCBA
definitions.

Change-Id: If9e554c072f01412164dc35e0b09272142e3796f
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/mainboard/google/butterfly/romstage.c
M src/mainboard/google/link/romstage.c
M src/mainboard/google/parrot/romstage.c
M src/mainboard/google/stout/romstage.c
M src/mainboard/samsung/lumpy/romstage.c
M src/mainboard/samsung/stumpy/romstage.c
M src/southbridge/intel/bd82x6x/early_rcba.c
M src/southbridge/intel/common/rcba.h
8 files changed, 15 insertions(+), 14 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/24924/2
-- 
To view, visit https://review.coreboot.org/24924
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9e554c072f01412164dc35e0b09272142e3796f
Gerrit-Change-Number: 24924
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180301/0517b121/attachment.html>


More information about the coreboot-gerrit mailing list