[coreboot-gerrit] Change in coreboot[master]: payloads/libpayload/drivers/i8042: Add macros for i8042 commands

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27289 )

Change subject: payloads/libpayload/drivers/i8042: Add macros for i8042 commands
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/27289/2/payloads/libpayload/drivers/i8042/i8042.h
File payloads/libpayload/drivers/i8042/i8042.h:

https://review.coreboot.org/#/c/27289/2/payloads/libpayload/drivers/i8042/i8042.h@44
PS2, Line 44: #define I8042_CMD_EN_KB 		0xae
please, no space before tabs


https://review.coreboot.org/#/c/27289/2/payloads/libpayload/drivers/i8042/i8042.h@45
PS2, Line 45: #define I8042_CMD_RD_INPUT_PORT 	0xc0
please, no space before tabs


https://review.coreboot.org/#/c/27289/2/payloads/libpayload/drivers/i8042/i8042.h@64
PS2, Line 64: #define I8042_KBCMD_DEFAULT_DIS 	0xf5
please, no space before tabs


https://review.coreboot.org/#/c/27289/2/payloads/libpayload/drivers/i8042/i8042.h@65
PS2, Line 65: #define I8042_KBCMD_SET_DEFAULT 	0xf6
please, no space before tabs



-- 
To view, visit https://review.coreboot.org/27289
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74b2388d048e35b5bdf5bd862d0975e88f1bd6af
Gerrit-Change-Number: 27289
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 30 Jun 2018 00:55:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180630/02c521ca/attachment.html>