[coreboot-gerrit] Change in coreboot[master]: [Do Not Merge] add i945G based mainboard
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Jun 29 23:30:05 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25509 )
Change subject: [Do Not Merge] add i945G based mainboard
......................................................................
Patch Set 13:
(46 comments)
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/cstates.c
File src/mainboard/nec/945g-m4/cstates.c:
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/cstates.c@20
PS13, Line 20: }
adding a line without newline at end of file
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c
File src/mainboard/nec/945g-m4/romstage.c:
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@59
PS13, Line 59: FDD_LPC_EN | KBC_LPC_EN |CNF1_LPC_EN |CNF2_LPC_EN);
need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@59
PS13, Line 59: FDD_LPC_EN | KBC_LPC_EN |CNF1_LPC_EN |CNF2_LPC_EN);
need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@92
PS13, Line 92: pnp_write_config(GPIO_MIDI_DEV, 0x60, 0x00);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@92
PS13, Line 92: pnp_write_config(GPIO_MIDI_DEV, 0x60, 0x00);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@93
PS13, Line 93: pnp_write_config(GPIO_MIDI_DEV, 0x61, 0x00);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@93
PS13, Line 93: pnp_write_config(GPIO_MIDI_DEV, 0x61, 0x00);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@94
PS13, Line 94: pnp_write_config(GPIO_MIDI_DEV, 0x62, 0x00);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@94
PS13, Line 94: pnp_write_config(GPIO_MIDI_DEV, 0x62, 0x00);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@95
PS13, Line 95: pnp_write_config(GPIO_MIDI_DEV, 0x63, 0x00);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@95
PS13, Line 95: pnp_write_config(GPIO_MIDI_DEV, 0x63, 0x00);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@96
PS13, Line 96: pnp_write_config(GPIO_MIDI_DEV, 0x70, 0x00);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@96
PS13, Line 96: pnp_write_config(GPIO_MIDI_DEV, 0x70, 0x00);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@97
PS13, Line 97: pnp_write_config(GPIO_MIDI_DEV, 0xf0, 0x5f);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@97
PS13, Line 97: pnp_write_config(GPIO_MIDI_DEV, 0xf0, 0x5f);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@98
PS13, Line 98: pnp_write_config(GPIO_MIDI_DEV, 0xf1, 0x5f);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@98
PS13, Line 98: pnp_write_config(GPIO_MIDI_DEV, 0xf1, 0x5f);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@127
PS13, Line 127: pnp_enter_conf_state(HWM_DEV);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@127
PS13, Line 127: pnp_enter_conf_state(HWM_DEV);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@128
PS13, Line 128: pnp_set_logical_device(HWM_DEV);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@128
PS13, Line 128: pnp_set_logical_device(HWM_DEV);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@129
PS13, Line 129: pnp_set_iobase(HWM_DEV, PNP_IDX_IO0, 0x290);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@129
PS13, Line 129: pnp_set_iobase(HWM_DEV, PNP_IDX_IO0, 0x290);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@149
PS13, Line 149: }
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@149
PS13, Line 149: }
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@171
PS13, Line 171: printk(BIOS_DEBUG, "program secondary mlt XXX byte \n");
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@173
PS13, Line 173: printk(BIOS_DEBUG, "reset rtc power status \n");
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@177
PS13, Line 177: printk(BIOS_DEBUG, "usb transient disconnect \n");
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@263
PS13, Line 263: printk(BIOS_DEBUG, "Enable SPD ROMs and DDR-II DRAM \n");
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@272
PS13, Line 272: printk(BIOS_DEBUG, "Perform some initialization that must run before stage2 \n");
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@276
PS13, Line 276: printk(BIOS_DEBUG, "Chipset Errata! \n");
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@279
PS13, Line 279: printk(BIOS_DEBUG, "Initialize the internal PCIe links before we go into stage2 \n");
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@285
PS13, Line 285: init_tpm(s3resume);
code indent should use tabs where possible
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/romstage.c@285
PS13, Line 285: init_tpm(s3resume);
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c
File src/mainboard/nec/945g-m4/superio_hwm.c:
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@83
PS13, Line 83: //if (get_option(&cpufan_temperature, "cpufan_temperature") != CB_SUCCESS)
line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@90
PS13, Line 90: //if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS)
line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@116
PS13, Line 116: case FAN_CRUISE_CONTROL_SPEED: fan_config |= (2 << 4); break;
trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@117
PS13, Line 117: case FAN_CRUISE_CONTROL_THERMAL: fan_config |= (1 << 4); break;
trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@120
PS13, Line 120: case FAN_CRUISE_CONTROL_SPEED: fan_config |= (2 << 2); break;
trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@121
PS13, Line 121: case FAN_CRUISE_CONTROL_THERMAL: fan_config |= (1 << 2); break;
trailing statements should be on next line
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@130
PS13, Line 130: hwm_write(0x06, fan_speeds[cpufan_speed].fan_in); // CPUFANIN target speed
line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@135
PS13, Line 135: temperatures[cpufan_temperature].deg_fahrenheit);
line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@136
PS13, Line 136: hwm_write(0x06, temperatures[cpufan_temperature].deg_celsius); // CPUFANIN target temperature
line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@144
PS13, Line 144: hwm_write(0x05, fan_speeds[sysfan_speed].fan_in); // SYSFANIN target speed
line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@149
PS13, Line 149: temperatures[sysfan_temperature].deg_fahrenheit);
line over 80 characters
https://review.coreboot.org/#/c/25509/13/src/mainboard/nec/945g-m4/superio_hwm.c@150
PS13, Line 150: hwm_write(0x05, temperatures[sysfan_temperature].deg_celsius); // SYSFANIN target temperature
line over 80 characters
--
To view, visit https://review.coreboot.org/25509
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5398b990c26d087afb20e4b1028a7a1cad4b3ee3
Gerrit-Change-Number: 25509
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 21:30:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180629/aacf4f3f/attachment.html>
More information about the coreboot-gerrit
mailing list