[coreboot-gerrit] Change in coreboot[master]: stoneyridge: Enable legacy IO

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27268 )

Change subject: stoneyridge: Enable legacy IO
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/27268/1/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/27268/1/src/soc/amd/stoneyridge/southbridge.c@378
PS1, Line 378: static void sb_enable_legacy_io(void)
I'm fine with this, but did you consider doing both at the same time since it's the same register?
sb_pm_decode_setup();



-- 
To view, visit https://review.coreboot.org/27268
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I533226ba764f567e348577d7fcf6ebe43336609a
Gerrit-Change-Number: 27268
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 15:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180629/f4ff08cd/attachment.html>