[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint: Use new common PMBASE API

Patrick Rudolph (Code Review) gerrit at coreboot.org
Fri Jun 29 10:46:29 CEST 2018


Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27280


Change subject: sb/intel/lynxpoint: Use new common PMBASE API
......................................................................

sb/intel/lynxpoint: Use new common PMBASE API

Change-Id: I4e62846d34af3d81d9b787a313caa6dabb275bcf
Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
---
M src/southbridge/intel/lynxpoint/early_pch.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/27280/1

diff --git a/src/southbridge/intel/lynxpoint/early_pch.c b/src/southbridge/intel/lynxpoint/early_pch.c
index cb4bc7e..37b7830 100644
--- a/src/southbridge/intel/lynxpoint/early_pch.c
+++ b/src/southbridge/intel/lynxpoint/early_pch.c
@@ -64,7 +64,7 @@
 {
 	printk(BIOS_DEBUG, "Disabling Watchdog reboot...");
 	RCBA32(GCS) = RCBA32(GCS) | (1 << 5);	/* No reset */
-	outw((1 << 11), DEFAULT_PMBASE | 0x60 | 0x08);	/* halt timer */
+	write_pmbase16(0x68, 1 << 11);	/* halt timer */
 	printk(BIOS_DEBUG, " done.\n");
 }
 
@@ -84,13 +84,13 @@
 	int is_s3 = 0;
 
 	/* Check PM1_STS[15] to see if we are waking from Sx */
-	pm1_sts = inw(DEFAULT_PMBASE + PM1_STS);
+	pm1_sts = read_pmbase16(PM1_STS);
 	if (pm1_sts & WAK_STS) {
 		/* Read PM1_CNT[12:10] to determine which Sx state */
-		pm1_cnt = inl(DEFAULT_PMBASE + PM1_CNT);
+		pm1_cnt = read_pmbase32(PM1_CNT);
 		if (((pm1_cnt >> 10) & 7) == SLP_TYP_S3) {
 			/* Clear SLP_TYPE. */
-			outl(pm1_cnt & ~(7 << 10), DEFAULT_PMBASE + PM1_CNT);
+			write_pmbase32(PM1_CNT, pm1_cnt & ~(7 << 10));
 			is_s3 = 1;
 		}
 	}

-- 
To view, visit https://review.coreboot.org/27280
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e62846d34af3d81d9b787a313caa6dabb275bcf
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180629/8c2c3dd1/attachment-0001.html>


More information about the coreboot-gerrit mailing list