[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Remove notify for power button

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Jun 29 07:22:44 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27271


Change subject: ec/google/chromeec: Remove notify for power button
......................................................................

ec/google/chromeec: Remove notify for power button

None of the mainboards using Chrome EC set SCI mask for power
button. Thus, the EC will never generate SCI for power button
events. This change removes the Notify call for power button as part
of clean up for getting rid of the power button device in coreboot.

BUG=b:110913245

Change-Id: I86c72fd82f1a0e6d5693ebbcd58e2aea808f8817
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/ec/google/chromeec/acpi/ec.asl
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/27271/1

diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index 6589ccf..94917dd 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -223,7 +223,6 @@
 	Method (_Q03, 0, NotSerialized)
 	{
 		Store ("EC: POWER BUTTON", Debug)
-		Notify (\_SB.PWRB, 0x80)
 	}
 
 	// AC Connected

-- 
To view, visit https://review.coreboot.org/27271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86c72fd82f1a0e6d5693ebbcd58e2aea808f8817
Gerrit-Change-Number: 27271
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180629/89a01e44/attachment-0001.html>


More information about the coreboot-gerrit mailing list