[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Fix unused pins and those with external terminations

Thu Jun 28 22:17:32 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27183 )

Change subject: mb/google/octopus: Fix unused pins and those with external terminations
......................................................................

Patch Set 3:

(32 comments)

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@96
PS3, Line 96: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@131
PS3, Line 131: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@133
PS3, Line 133: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@134
PS3, Line 134: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@137
PS3, Line 137: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@141
PS3, Line 141: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@166
PS3, Line 166: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@175
PS3, Line 175: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@198
PS3, Line 198: 	PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@203
PS3, Line 203: 	PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@225
PS3, Line 225: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@227
PS3, Line 227: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@248
PS3, Line 248: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@258
PS3, Line 258: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/baseboard/gpio.c@285
PS3, Line 285: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@94
PS3, Line 94: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@136
PS3, Line 136: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@138
PS3, Line 138: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@139
PS3, Line 139: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@142
PS3, Line 142: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@146
PS3, Line 146: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@171
PS3, Line 171: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@177
PS3, Line 177: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_120, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ0_B -- unused */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@180
PS3, Line 180: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@204
PS3, Line 204: 	PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@205
PS3, Line 205: 	PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@210
PS3, Line 210: 	PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@232
PS3, Line 232: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@234
PS3, Line 234: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@255
PS3, Line 255: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@265
PS3, Line 265: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */
line over 80 characters

https://review.coreboot.org/#/c/27183/3/src/mainboard/google/octopus/variants/bip/gpio.c@292
PS3, Line 292: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

-- 
To view, visit https://review.coreboot.org/27183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ec62913b0ef47105289838218f5d74c004223c
Gerrit-Change-Number: 27183
Gerrit-PatchSet: 3
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Shamile Khan <shamile at gmail.com>
Gerrit-Comment-Date: Thu, 28 Jun 2018 20:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180628/2c2b8e7b/attachment.html>