[coreboot-gerrit] Change in coreboot[master]: arch/x86: add SMM caller

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Jun 28 18:16:29 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25193 )

Change subject: arch/x86: add SMM caller
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/25193/2/src/arch/x86/include/smm.h
File src/arch/x86/include/smm.h:

https://review.coreboot.org/#/c/25193/2/src/arch/x86/include/smm.h@25
PS2, Line 25: static inline u32 call_smm(u8 cmd, u8 subcmd, void *arg) {
open brace '{' following function declarations go on the next line



-- 
To view, visit https://review.coreboot.org/25193
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9cc626dae9a7751034615ef409eebc6035f5c3
Gerrit-Change-Number: 25193
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 28 Jun 2018 16:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180628/6eba1ce1/attachment.html>


More information about the coreboot-gerrit mailing list