[coreboot-gerrit] Change in coreboot[master]: src/device: Add check for existence and validity of PCIE base address...

Aamir Bohra (Code Review) gerrit at coreboot.org
Thu Jun 28 14:07:18 CEST 2018


Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/27263


Change subject: src/device: Add check for existence and validity of PCIE base address config
......................................................................

src/device: Add check for existence and validity of PCIE base address config

Signed-off-by: Aamir Bohra <aamir.bohra at intel.com>
Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518d
---
M src/device/pci_ops_mmconf.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/27263/1

diff --git a/src/device/pci_ops_mmconf.c b/src/device/pci_ops_mmconf.c
index fb085a6..e822ead 100644
--- a/src/device/pci_ops_mmconf.c
+++ b/src/device/pci_ops_mmconf.c
@@ -17,6 +17,10 @@
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
 
+#if !defined(CONFIG_MMCONF_BASE_ADDRESS) || !CONFIG_MMCONF_BASE_ADDRESS
+#error "PCI Express MMIO base address (PCIEXBAR) needs to be non-zero!"
+#endif
+
 /*
  * Functions for accessing PCI configuration space with mmconf accesses
  */

-- 
To view, visit https://review.coreboot.org/27263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89b0e9c927d395ac6d27201e0b3a8658e958518d
Gerrit-Change-Number: 27263
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180628/99cc9f40/attachment.html>


More information about the coreboot-gerrit mailing list