[coreboot-gerrit] Change in coreboot[master]: intel/common/block/scs: Add ability to send early CMD0, CMD1

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25068 )

Change subject: intel/common/block/scs: Add ability to send early CMD0, CMD1
......................................................................


Patch Set 9:

(3 comments)

https://review.coreboot.org/#/c/25068/9/src/soc/intel/common/block/include/intelblocks/early_mmc.h
File src/soc/intel/common/block/include/intelblocks/early_mmc.h:

https://review.coreboot.org/#/c/25068/9/src/soc/intel/common/block/include/intelblocks/early_mmc.h@27
PS9, Line 27:  * 					(Rx_CMD_Data_dly_1)—Offset 82Ch
please, no space before tabs


https://review.coreboot.org/#/c/25068/9/src/soc/intel/common/block/include/intelblocks/early_mmc.h@29
PS9, Line 29:  * 					(Rx_Strobe_Ctrl_Path)—Offset 830h
please, no space before tabs


https://review.coreboot.org/#/c/25068/9/src/soc/intel/common/block/include/intelblocks/early_mmc.h@31
PS9, Line 31:  * 					(Rx_CMD_Data_dly_2)—Offset 834h
please, no space before tabs



-- 
To view, visit https://review.coreboot.org/25068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3488b077bf5100a1e0f2c879fb1436105607d25e
Gerrit-Change-Number: 25068
Gerrit-PatchSet: 9
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-Comment-Date: Thu, 28 Jun 2018 01:21:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180628/3ebecb0e/attachment.html>