[coreboot-gerrit] Change in coreboot[master]: [WIP] soc/intel/apollolake: Use bootblock common stage

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Jun 27 01:25:32 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25802 )

Change subject: [WIP] soc/intel/apollolake: Use bootblock common stage
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/25802/11/src/soc/intel/apollolake/bootblock/bootblock.c
File src/soc/intel/apollolake/bootblock/bootblock.c:

https://review.coreboot.org/#/c/25802/11/src/soc/intel/apollolake/bootblock/bootblock.c@112
PS11, Line 112: 	return (struct bootblock_ops*)&g_soc_bb_ops;
"(foo*)" should be "(foo *)"



-- 
To view, visit https://review.coreboot.org/25802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I319453c902632f26eec63ab9c1e9bb6956b466fb
Gerrit-Change-Number: 25802
Gerrit-PatchSet: 11
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 26 Jun 2018 23:25:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180626/c1ef7aa6/attachment.html>


More information about the coreboot-gerrit mailing list