[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 )

Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb
......................................................................


Patch Set 47:

(8 comments)

https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c
File src/soc/intel/skylake/p2sb.c:

https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@23
PS47, Line 23:         if (count != P2SB_EP_MASK_MAX_REG) {
code indent should use tabs where possible


https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@23
PS47, Line 23:         if (count != P2SB_EP_MASK_MAX_REG) {
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@24
PS47, Line 24:                 printk(BIOS_ERR, "Unable to program EPMASK registers\n");
code indent should use tabs where possible


https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@24
PS47, Line 24:                 printk(BIOS_ERR, "Unable to program EPMASK registers\n");
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@25
PS47, Line 25:                 return;
code indent should use tabs where possible


https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@25
PS47, Line 25:                 return;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@26
PS47, Line 26:         }
code indent should use tabs where possible


https://review.coreboot.org/#/c/26132/47/src/soc/intel/skylake/p2sb.c@26
PS47, Line 26:         }
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/26132
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a
Gerrit-Change-Number: 26132
Gerrit-PatchSet: 47
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Dhaval Sharma <dhaval.v.sharma at intel.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 16:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180626/32cf8a57/attachment.html>