[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU

Furquan Shaikh (Code Review) gerrit at coreboot.org
Tue Jun 26 02:33:57 CEST 2018


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27220 )

Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/27220/2/src/mainboard/google/poppy/variants/nautilus/mainboard.c
File src/mainboard/google/poppy/variants/nautilus/mainboard.c:

https://review.coreboot.org/#/c/27220/2/src/mainboard/google/poppy/variants/nautilus/mainboard.c@16
PS2, Line 16: boardid
is this still needed?



-- 
To view, visit https://review.coreboot.org/27220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36
Gerrit-Change-Number: 27220
Gerrit-PatchSet: 2
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 26 Jun 2018 00:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180626/219c43e6/attachment.html>


More information about the coreboot-gerrit mailing list