[coreboot-gerrit] Change in coreboot[master]: intel/common: change mca_configure API's def

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26391 )

Change subject: intel/common: change mca_configure API's def
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/cpu/cpulib.c
File src/soc/intel/common/block/cpu/cpulib.c:

https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/cpu/cpulib.c@309
PS2, Line 309: 	printk(BIOS_DEBUG, "CPU: mca_configure num banks %d\n", num_banks);
Prefer using '"%s...", __func__' to using 'mca_configure', this function's name, in a string


https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/include/intelblocks/cpulib.h
File src/soc/intel/common/block/include/intelblocks/cpulib.h:

https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/include/intelblocks/cpulib.h@160
PS2, Line 160: void mca_configure(void* unused);
"foo* bar" should be "foo *bar"



-- 
To view, visit https://review.coreboot.org/26391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2395ee7fbedc829f040959b0021967f800693eeb
Gerrit-Change-Number: 26391
Gerrit-PatchSet: 2
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 25 Jun 2018 23:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180625/8d573d18/attachment.html>