[coreboot-gerrit] Change in coreboot[master]: smm: Clear SMRAM when debugging
Raul Rangel (Code Review)
gerrit at coreboot.org
Mon Jun 25 20:06:33 CEST 2018
Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/27227
Change subject: smm: Clear SMRAM when debugging
......................................................................
smm: Clear SMRAM when debugging
This makes it easier to spot unused RAM.
BUG=b:80539294
TEST=built and tested on grunt. Verified unused memory was set to 0xcdcdcdcd
Change-Id: I335eaf642bd8526f31819eaac95ce80c2df3c300
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
---
M src/cpu/x86/smm/smm_module_loader.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/27227/1
diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index 3d7952f..e92fa05 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -346,6 +346,10 @@
if (rmodule_parse(&_binary_smm_start, &smm_mod))
return -1;
+ /* Clear SMM region */
+ if (IS_ENABLED(CONFIG_DEBUG_SMI))
+ memset(smram, 0xcd, size);
+
total_stack_size = params->per_cpu_stack_size *
params->num_concurrent_stacks;
--
To view, visit https://review.coreboot.org/27227
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I335eaf642bd8526f31819eaac95ce80c2df3c300
Gerrit-Change-Number: 27227
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180625/c2ea5d7f/attachment-0001.html>
More information about the coreboot-gerrit
mailing list