[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
Seunghwan Kim (Code Review)
gerrit at coreboot.org
Mon Jun 25 12:22:20 CEST 2018
Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/27220
Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
......................................................................
mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
We would use GPP_B20 instead of board id to determine nautilus SKU.
BUG=80052672
BRANCH=poppy
TEST=Verified the new coreboot could determine SKU correctly
Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36
Signed-off-by: Seunghwan Kim <sh_.kim at samsung.com>
---
M src/mainboard/google/poppy/variants/nautilus/mainboard.c
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/27220/1
diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c
index b4ef1c2..6ee08ef 100644
--- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c
@@ -16,6 +16,7 @@
#include <boardid.h>
#include <baseboard/variants.h>
#include <chip.h>
+#include <gpio.h>
#include <device/device.h>
#include <variant/sku.h>
@@ -26,7 +27,13 @@
if (sku_id != SKU_UNKNOWN)
return sku_id;
- if (board_id() < 9)
+ /*
+ * Nautilus uses GPP_B20 to determine SKU
+ * 0 - Wifi SKU
+ * 1 - LTE SKU
+ */
+ gpio_input_pulldown(GPP_B20);
+ if (!gpio_get(GPP_B20))
sku_id = SKU_0_NAUTILUS;
else
sku_id = SKU_1_NAUTILUS_LTE;
--
To view, visit https://review.coreboot.org/27220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36
Gerrit-Change-Number: 27220
Gerrit-PatchSet: 1
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180625/5850cf07/attachment.html>
More information about the coreboot-gerrit
mailing list