[coreboot-gerrit] Change in coreboot[master]: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27218 )

Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default
......................................................................


Patch Set 1:

(1 comment)

HAVE_IFD_BIN is about having the file in the repo. We have the file
for the boards that currently don't override the default. So they
need an override now.

I would prefer a single commit that inverts the chipset default,
adds a `default y` override (or even better `select HAVE_IFD_BIN`)
for the affected boards that currently don't have an override and
removes all the `default n` board overrides.

https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconfig
File src/southbridge/intel/bd82x6x/Kconfig:

https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconfig@69
PS1, Line 69: config HAVE_IFD_BIN
            : 	def_bool n
            : 
            : config BUILD_WITH_FAKE_IFD
            : 	def_bool n
Can drop these they should already default to n implicitly.



-- 
To view, visit https://review.coreboot.org/27218
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I330c4886f8bea4b1a8ecad6505a0e5cc381654d1
Gerrit-Change-Number: 27218
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 24 Jun 2018 14:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180624/ec9d3daf/attachment.html>