[coreboot-gerrit] Change in coreboot[master]: mb/gigabyte/ga-{h61m-s2pv, b75m-d3h, b75m-d3v}: Clean up CMOS files

Angel Pons (Code Review) gerrit at coreboot.org
Sun Jun 24 12:38:36 CEST 2018


Angel Pons has uploaded this change for review. ( https://review.coreboot.org/27217


Change subject: mb/gigabyte/ga-{h61m-s2pv,b75m-d3h,b75m-d3v}: Clean up CMOS files
......................................................................

mb/gigabyte/ga-{h61m-s2pv,b75m-d3h,b75m-d3v}: Clean up CMOS files

Options that were deemed unneceesary on other code reviews have
been removed from the layout files. In addition, the checksummed
range has been extended to cover sata_mode and gfx_uma_size.

Change-Id: Id9e904f447809231806a786e39ed638f21e1bc5a
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
---
M src/mainboard/gigabyte/ga-b75m-d3h/cmos.default
M src/mainboard/gigabyte/ga-b75m-d3h/cmos.layout
M src/mainboard/gigabyte/ga-b75m-d3v/cmos.default
M src/mainboard/gigabyte/ga-b75m-d3v/cmos.layout
M src/mainboard/gigabyte/ga-h61m-s2pv/cmos.layout
5 files changed, 7 insertions(+), 34 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/27217/1

diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/cmos.default b/src/mainboard/gigabyte/ga-b75m-d3h/cmos.default
index a313f68..6f3cec7 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3h/cmos.default
+++ b/src/mainboard/gigabyte/ga-b75m-d3h/cmos.default
@@ -1,7 +1,6 @@
 boot_option=Fallback
-debug_level=Spew
+debug_level=Debug
 power_on_after_fail=Enable
 nmi=Enable
-volume=0x3
 sata_mode=AHCI
-hyper_threading=Enable
+gfx_uma_size=32M
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/cmos.layout b/src/mainboard/gigabyte/ga-b75m-d3h/cmos.layout
index 7c72c4b..23b8fb3 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3h/cmos.layout
+++ b/src/mainboard/gigabyte/ga-b75m-d3h/cmos.layout
@@ -52,8 +52,6 @@
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
-
 # coreboot config options: southbridge
 408          1       e       1        nmi
 409          2       e       7        power_on_after_fail
@@ -63,18 +61,12 @@
 #422	    2	    r	    0	     unused
 
 # coreboot config options: cpu
-424          1       e       2        hyper_threading
 #425        7       r       0        unused
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
 #435        549       r       0        unused
 
-# SandyBridge MRC Scrambler Seed values
-896         32        r       0        mrc_scrambler_seed
-928         32        r       0        mrc_scrambler_seed_s3
-960         16        r       0        mrc_scrambler_seed_chk
-
 # coreboot config options: check sums
 984         16       h       0        check_sum
 
@@ -85,8 +77,6 @@
 #ID value   text
 1     0     Disable
 1     1     Enable
-2     0     Enable
-2     1     Disable
 4     0     Fallback
 4     1     Normal
 6     0     Emergency
@@ -114,4 +104,4 @@
 # -----------------------------------------------------------------
 checksums
 
-checksum 392 415 984
+checksum 392 439 984
diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/cmos.default b/src/mainboard/gigabyte/ga-b75m-d3v/cmos.default
index a313f68..6f3cec7 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3v/cmos.default
+++ b/src/mainboard/gigabyte/ga-b75m-d3v/cmos.default
@@ -1,7 +1,6 @@
 boot_option=Fallback
-debug_level=Spew
+debug_level=Debug
 power_on_after_fail=Enable
 nmi=Enable
-volume=0x3
 sata_mode=AHCI
-hyper_threading=Enable
+gfx_uma_size=32M
diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/cmos.layout b/src/mainboard/gigabyte/ga-b75m-d3v/cmos.layout
index 7c72c4b..23b8fb3 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3v/cmos.layout
+++ b/src/mainboard/gigabyte/ga-b75m-d3v/cmos.layout
@@ -52,8 +52,6 @@
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
-
 # coreboot config options: southbridge
 408          1       e       1        nmi
 409          2       e       7        power_on_after_fail
@@ -63,18 +61,12 @@
 #422	    2	    r	    0	     unused
 
 # coreboot config options: cpu
-424          1       e       2        hyper_threading
 #425        7       r       0        unused
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
 #435        549       r       0        unused
 
-# SandyBridge MRC Scrambler Seed values
-896         32        r       0        mrc_scrambler_seed
-928         32        r       0        mrc_scrambler_seed_s3
-960         16        r       0        mrc_scrambler_seed_chk
-
 # coreboot config options: check sums
 984         16       h       0        check_sum
 
@@ -85,8 +77,6 @@
 #ID value   text
 1     0     Disable
 1     1     Enable
-2     0     Enable
-2     1     Disable
 4     0     Fallback
 4     1     Normal
 6     0     Emergency
@@ -114,4 +104,4 @@
 # -----------------------------------------------------------------
 checksums
 
-checksum 392 415 984
+checksum 392 439 984
diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/cmos.layout b/src/mainboard/gigabyte/ga-h61m-s2pv/cmos.layout
index 8bafc6f..23b8fb3 100644
--- a/src/mainboard/gigabyte/ga-h61m-s2pv/cmos.layout
+++ b/src/mainboard/gigabyte/ga-h61m-s2pv/cmos.layout
@@ -67,11 +67,6 @@
 432         3        e      11        gfx_uma_size
 #435        549       r       0        unused
 
-# SandyBridge MRC Scrambler Seed values
-896         32        r       0        mrc_scrambler_seed
-928         32        r       0        mrc_scrambler_seed_s3
-960         16        r       0        mrc_scrambler_seed_chk
-
 # coreboot config options: check sums
 984         16       h       0        check_sum
 
@@ -109,4 +104,4 @@
 # -----------------------------------------------------------------
 checksums
 
-checksum 392 415 984
+checksum 392 439 984

-- 
To view, visit https://review.coreboot.org/27217
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9e904f447809231806a786e39ed638f21e1bc5a
Gerrit-Change-Number: 27217
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180624/db360b28/attachment.html>


More information about the coreboot-gerrit mailing list